Skip to content

[deps]: Update electron-store to v11 - abandoned - #901

Closed
renovate[bot] wants to merge 2 commits into
mainfrom
renovate/electron-store-11.x
Closed

[deps]: Update electron-store to v11 - abandoned#901
renovate[bot] wants to merge 2 commits into
mainfrom
renovate/electron-store-11.x

Conversation

@renovate

@renovate renovate Bot commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
electron-store 8.2.0 -> 11.0.2 age confidence

Release Notes

sindresorhus/electron-store (electron-store)

v11.0.2

Compare Source


v11.0.1

Compare Source


v11.0.0

Compare Source


v10.1.0

Compare Source


v10.0.1

Compare Source


v10.0.0

Compare Source

Breaking

This is only a breaking change if you use the schema option.

v9.0.0

Compare Source

Breaking
  • Require Node.js 20 and Electron 30 7ddf0c6
  • This package is now pure ESM. Please read this and this.
    • For TypeScript users, make sure you have the correct tsconfig.
Improvements

Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested a review from a team as a code owner October 13, 2025 02:53
@renovate
renovate Bot requested a review from jrmccannon October 13, 2025 02:53
@bitwarden-bot bitwarden-bot changed the title [deps]: Update electron-store to v11 [PM-26891] [deps]: Update electron-store to v11 Oct 13, 2025
@bitwarden-bot

Copy link
Copy Markdown

Internal tracking:

@codecov

codecov Bot commented Oct 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.01%. Comparing base (9a719c9) to head (de8dc97).
⚠️ Report is 86 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #901   +/-   ##
=======================================
  Coverage   16.01%   16.01%           
=======================================
  Files          67       67           
  Lines        2791     2791           
  Branches      481      481           
=======================================
  Hits          447      447           
  Misses       2306     2306           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@renovate renovate Bot changed the title [PM-26891] [deps]: Update electron-store to v11 [deps]: Update electron-store to v11 Oct 13, 2025
@renovate
renovate Bot force-pushed the renovate/electron-store-11.x branch from 73b8ab7 to 9609e55 Compare October 21, 2025 18:43
@renovate
renovate Bot force-pushed the renovate/electron-store-11.x branch from 9609e55 to 8a612fd Compare November 10, 2025 16:47
@renovate
renovate Bot force-pushed the renovate/electron-store-11.x branch from 8a612fd to 64e29d2 Compare November 18, 2025 13:23
@renovate
renovate Bot force-pushed the renovate/electron-store-11.x branch from 64e29d2 to b1fb865 Compare December 3, 2025 14:39
@renovate renovate Bot added the major-update label Dec 3, 2025
@renovate
renovate Bot force-pushed the renovate/electron-store-11.x branch from b1fb865 to d9a5d8c Compare December 12, 2025 21:05
@github-actions

github-actions Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf3c6022b-0cdb-4adb-ba4e-7d652818435c

Great job! No new security vulnerabilities introduced in this pull request

@claude

claude Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Claude finished @renovate[bot]'s task in 2m 46s —— View job


PR Review: electron-store v8 → v11 Update

Tasks:

  • Review the dependency update scope
  • Analyze code changes for breaking change handling
  • Run automated code review

Review Complete ✅

The code review agent has analyzed the changes and posted detailed inline comments on the PR. Key findings:

Breaking Changes Handled:

  • ✅ ESM import migration (replaced require() with import)
  • ✅ Node 20 & Electron 30+ requirements met
  • ⚠️ TypeScript config change needs validation

Issues Identified:

  1. Type safety: store property uses any instead of proper typing
  2. Webpack config: May need to add electron-store to externals
  3. moduleResolution change: From "node" to "bundler" needs testing

Please review the inline comments for detailed recommendations.


const Store = require("electron-store");

export class ElectronStorageService implements StorageService {
private store: any;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type Safety Issue: The store property is typed as any, which defeats TypeScript's type safety.

Since electron-store v11 is now written in TypeScript with proper type definitions, you should use proper typing:

Suggested change
private store: any;
private store: Store<Record<string, unknown>>;

Or if you know the specific shape of your data, define a proper interface for the store schema.

Comment thread tsconfig.json
"compilerOptions": {
"pretty": true,
"moduleResolution": "node",
"moduleResolution": "bundler",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration Concern: Changing moduleResolution from "node" to "bundler" is a significant change that affects how TypeScript resolves module imports.

While "bundler" is appropriate for bundled applications, this change should be carefully tested because:

  1. It changes how conditional exports are resolved
  2. It allows importing ESM modules from CJS contexts (which may hide issues)
  3. It affects how package.json exports fields are interpreted

Since you're using Webpack to bundle the application, this change seems reasonable, but you should verify:

  • The application builds successfully
  • All imports resolve correctly at runtime
  • No module resolution errors occur in production

Consider also checking if you need to update the webpack configuration's resolve.conditionNames to match this change.

import * as fs from "fs";

import { ipcMain } from "electron";
import Store from "electron-store";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good: The migration from CommonJS require() to ESM import is correct for electron-store v11.

However, there are some additional concerns to address:

  1. Missing webpack configuration: Since electron-store v11 is pure ESM, you may need to add it to webpack externals in webpack.main.js to prevent bundling issues:

    externals: {
      "electron-reload": "commonjs2 electron-reload",
      "electron-store": "commonjs2 electron-store",  // Add this
      keytar: "commonjs2 keytar",
    },
  2. Type safety: The store property on line 11 is still typed as any. Consider using proper typing:

    private store: Store<Record<string, unknown>>;
  3. Verify compatibility: Electron-store v11 requires Electron 30+. Ensure your electron dependency meets this requirement (I see you have v39.2.1, so this is fine).

@eliykat eliykat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I suggest we hold off until we look at ESM support properly next year.

@renovate

renovate Bot commented Dec 13, 2025

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@renovate renovate Bot changed the title [deps]: Update electron-store to v11 [deps]: Update electron-store to v11 - abandoned Apr 14, 2026
@renovate

renovate Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@eliykat

eliykat commented Apr 15, 2026

Copy link
Copy Markdown
Member

Updated to 11 in #1034

@eliykat eliykat closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants